NYCPlanning / ceqr-app

Web Application supporting the City Environmental Quality Review (CEQR) process
https://www.ceqr.app
12 stars 6 forks source link

Migrate 2017 & 2018 Public Schools data packages & datasets to follow 2019 schema #626

Closed bfreeds closed 4 years ago

bfreeds commented 4 years ago

Currently public schools data packages organize sca_bluebook and doe_lcgms datasets as two distinct tables. For the 2019 data update, EDM is combining them into one dataset, which better represent the information (doe_lcgms is really an extension of sca_bluebook to add more detail/schools that aren't in bluebook, but they follow the same schema).

The public_schools data packages need to follow the same schema for all years (2017, 2018, and 2019) - otherwise we will have to add conditional logic on the backend and frontend to allow for a user who is switching between data packages within the public schools analysis to accomodate this difference between data package schemas.

As it is now, lcgms and bluebooks schools are being merged in the frontend model. By addressing this upstream in the backend data model, we can refactor to simplify the Ember public schools analysis model.

For this issue, we need to:

Related to #484

trbmcginnis commented 4 years ago

Closing this because it'll be covered in #630