NYCPlanning / ceqr-app

Web Application supporting the City Environmental Quality Review (CEQR) process
https://www.ceqr.app
12 stars 6 forks source link

Create ceqr_school_buildings tables in ceqr_data database #628

Closed bfreeds closed 4 years ago

bfreeds commented 4 years ago

EDM has created a pipeline for combining lcgms and bluebook datasets into a new ceqr_school_buildings dataset.

We need to match 2017 and 2018 tables to this schema. We should use the same pipeline recipe EDM has developed to ensure the process is identical. This recipe should be applied directly to ceqr_data to make the new 2017 and 2018 tables.

Note: This won't have a draft PR because we'll run the script manually to create the 2 new tables.

bfreeds commented 4 years ago

EDM has run their recipe for 2017 and 2018 data, all we need to do is bring those two tables over into ceqr_data.

bfreeds commented 4 years ago

Manually brought these EDM tables into ceqr_data image .

by following the process documented in /data/air-quality/makefile.

Decided not to add this to the makefile data pipeline because after learning about other data pipelines used (by EDM, in Layers-API), I don't think Make is the way we should do this - Python and following existing processes would make more sense.

Since this was a one-time migration, I just went ahead and did it manually and assume that we'll use this Github issue for documenting historical process.