search

NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

add geospatial check table #193

Closed Oysters1874 closed 2 years ago

Oysters1874 commented 2 years ago

Addresses the issue here. Thanks to Te's great work, we display two parts for the geospatial check, one is to check whether all properties are within NYC borough boundaries water included, the other is to check whether there is any inconsistency between geographies.

SashaWeinstein commented 2 years ago

This is how I got get_data to run under the current organization of DO:

    if branch == "dev":
        url = f"https://edm-publishing.nyc3.digitaloceanspaces.com/db-colp/{branch}/latest/output/qaqc"
    else:
        url = f"https://edm-publishing.nyc3.digitaloceanspaces.com/db-colp/{branch}/latest/output"

Obviously not ideal lol. We could limit the user to seeing dev for now, that might be the easiest way forward

SashaWeinstein commented 2 years ago

I have 3 comments on how the tables are laid out:

  1. Can we put uid all the way to the right? So a user can scroll to it if they find the record they are looking for, or want to do more research. Having it on the left takes the place of more helpful columns
  2. Can we recast version to be a human readable year-month?
  3. Can we add an expected_bbl_boro and expected_cd_boro to the Properties That Have Inconsistent Geographies table? This might be a colp-side upgrade