search

NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

175 version to version report #197

Closed abrieff closed 2 years ago

abrieff commented 2 years ago

Addresses #175 Version to version comparison for usetype for colp - allows filtering by version, although it seems only version available is current one. That may need guidance as to what the dropdown should show

Oysters1874 commented 2 years ago

I think in general this looks great. Due to the large number of use types, I am wondering whether it will be better if we just include use types that experience a change between versions.

SashaWeinstein commented 2 years ago

Getting 

File "/workspaces/data-engineering-qaqc/src/colp/components/usetype_version_comparison_report.py", line 66, in get_previous_version
    return df.iloc[0]["v_previous"]

Would it be hepful for me to try and debug?

SashaWeinstein commented 2 years ago

I made a new feature branch with the sidebar version dropdown controlled by the home page file. Here's the commit of that change. What do you think about that?

abrieff commented 2 years ago

The reason I put it back is because you then need to include the logic to handle the data being empty in the colp.py file to not cause an error - don't have a strong opinion though, figured it could be moved when we had a better/more stable way to include versions. We can just put that in colp also - if you wanna add that to your feature branch and merge it in thats fine w/me!

abrieff commented 2 years ago

Now that sasha and I have both contributed, this needs an additional reviewer if anyone has the time

td928 commented 2 years ago

assigned myself and going to take a closer look on this