search

NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

Improve PLUTO Null Graph #202

Closed Oysters1874 closed 2 years ago

Oysters1874 commented 2 years ago

Addresses the issue here.

As Amanda points out, we want to limit the graph to report fields where NULL is a value in the field. I checked the PLUTO data, and discovered that borough, block, lot, residfar, commfar, facilfar, borocode, bbl, plutomapid, and version do not have null values. And I assume these fields won't have a NULL value in it in any version (correct me if I am wrong). As for zonedist4 and spdist3, although there is no change of null counts for these two fields, we should still display them as NULL always exists. I think modifying the displayed fields manually may be the most convenient way.

Oysters1874 commented 2 years ago

I changed the original line chart to a bar chart within an interactive slidebar that allows user to select the range of fields to view. All fields are included.

Oysters1874 commented 2 years ago

No need to apologize! One small thing is that a human-readable range goes from 1 to x, whereas the python range goes from 0 to x. So I think we want the min value in the slider to be 1, and subtract that one off that integer so selected = fields[range[0]-1: range[1]]. Does that seem right to you? So easy to be off by one with these things

yea, that makes sense.