NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

Digital ocean client dynamically constructs url #220

Closed SashaWeinstein closed 1 year ago

SashaWeinstein commented 2 years ago

Does it make sense to construct the base of the url as f"https://{bucket_name}.nyc3.digitaloceanspaces.com" and do this in the client? I can make this improvement just wanted to get your thoughts @abrieff

abrieff commented 2 years ago

Yeah that seems right

SashaWeinstein commented 1 year ago

Out of date now that the digital ocean client uses boto3