search

NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

Merge into main for deployment #223

Closed SashaWeinstein closed 2 years ago

SashaWeinstein commented 2 years ago

Should be a quick review 🌟 I would appreciate it if at least one other person ran the dev version of the app on their local to make sure nothing is obviously wrong. Then we can deploy this afternoon

mbh329 commented 2 years ago

I looked through all the pages on dev and everything worked (besides geosupport demo which we obviously didn't touch). One thing I noticed was that in the fac-db page is that the pick a branch drop down menu is reading in this dependabot/pip/dashboard/streamlit-1.1.1 branch which is bizarre. I can take a further look at this but don't think it warrants holding up the deployment unless anyone thinks otherwise

mbh329 commented 2 years ago

Interesting. Githubs dependabot feature opened a PR on fac-db to update streamlit because it found vulnerabilities with the version of streamlit https://github.com/NYCPlanning/db-facilities/pull/580