search

NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

Fix protobuf version #233

Closed SashaWeinstein closed 2 years ago

SashaWeinstein commented 2 years ago

Previous PR from this feature branch mistakenly pointed to dev, that was my bad

SashaWeinstein commented 2 years ago

@mbh329 this will be ready for review once I address the merge conflict

mbh329 commented 2 years ago

Ahh shoot, sorry I didn't catch this either

SashaWeinstein commented 2 years ago

All good this is actually a new PR after I pointed the old one to the wrong branch

mbh329 commented 2 years ago

This went off my radar but I just checked the app on the feature branch and there was an indexerror on the pluto page. t I can look at this in more detail after standup

SashaWeinstein commented 2 years ago

Ah frustrating. I should have ran it myself, assumed the poetry updates wouldn't effect functionality. I'll take a look today

SashaWeinstein commented 2 years ago

Ah ok great. You should pull down the most recent version of master. And approve this PR as well