NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

Create Drop Down Menu to Pick Previous Version Dynamically #240

Closed mbh329 closed 2 years ago

mbh329 commented 2 years ago

Addresses issue #239 scoped out by Sasha. Small PR - one reviewer ⭐

CPDB version's were previously set by hardcoding in the previous version but this makes it very difficult to maintain and users aren't able to confirm which version is set as previous. To rectify this, I created a drop down menu that allows the user to set the previous version (with the default being latest therefore you won't see any difference counts in the graphs unless you choose a different previous version). I chose to only include published version of CPDB (2022-10-25 AKA 22_adopted, 20202-06-08 AKA 22_executive, 2022-04-08 AKA 22_preliminary) because these are the version of most interest for EDM and to avoid any confusion for other teams who might use the app.

NOTE

CPDB folder naming structure might need to change at some point. Currently, its difficult to know which version of CPDB is a published version (sent to Capital Planning -> QAQC'd -> approved by CP -> sent to OSE -> published on CPE). I think we should think about how we want to keep our published version of cpdb separate from other builds of cpdb on main. As of now, I had to look through emails to identify which versions of cpdb are published and that makes it difficult to trace which version of CPDB are published vs. others.