NYCPlanning / data-engineering-qaqc

streamlit app for data engineering
https://edm-data-engineering.nycplanningdigital.com
1 stars 0 forks source link

Fvk 2023 q2 gru #261

Closed fvankrieken closed 1 year ago

fvankrieken commented 1 year ago

Addresses these two issues in gru qaqc

See PR here for related changes to that repo

This will need an app token added to the running environment of the app

fvankrieken commented 1 year ago
fvankrieken commented 1 year ago

Merging this is blocked by just a couple little things in the db-gru-qaqc branch, but it's ready for review.

i deployed changes for now, check out

https://edm-data-engineering.nycplanningdigital.com/?page=GRU+QAQC

Running locally requires generating a github access token, I'll maybe add a note to the readme since this is our only repo that has that

fvankrieken commented 1 year ago

Ooh running workflow from the app fails. Maybe not ready for review after all

fvankrieken commented 1 year ago

Interestingly, issue was on db-gru-qaqc side. I had updated the workflow file to have options for inputs rather than free text field, but this caused a 422 (unprocessable entity) error when trying to specify input for the workflow dispatch via github api