add a diagram to show the desired GFT lot zoning logic
add a test to validate the logic in int_flags__zoning
It uses the same approach as our pilot project test by comparing a seed table (expected values) to build records (actual values) using dbt_utils.equality.
Although the focus is on comparing the Zoning District column, the zonedist columns are included to emphasize why certain values are expected (for a human, bbl is not enough to deduce the expected Zoning District)
add a dbt analysis named pluto_zoning_district_groups
It's a very informative query to see all unique combinations of zonedist values in PLUTO.
related to #741
changes
int_flags__zoningdbt_utils.equality.Zoning Districtcolumn, thezonedistcolumns are included to emphasize why certain values are expected (for a human, bbl is not enough to deduce the expectedZoning District)pluto_zoning_district_groupszonedistvalues in PLUTO.GFT builds
New test failing here as expected.
New test warning here to not block building on main for now. Will make changes to the expected values and logic in a follow-up PR.
notes
analysis query
pluto_zoning_district_groupsSeeing all distinct
zonedistcombinations has been useful and interesting enough that it seems worth preserving. There seem to be 1,969 combinations.Screenshot of the most frequent lot zoning:
Screenshot of the most frequent zoning groups including "a value + ALL other values":