search

NYCPlanning / data-engineering

Primary repository for NYC DCP's Data Engineering team
14 stars 0 forks source link

clean up python reqs, dcpy install #750

Closed fvankrieken closed 2 months ago

fvankrieken commented 2 months ago

Had an odd failed job here

Couple things going on. For some reason, during dcpy install in container, it's uninstalling and reinstalling some python packages. On top of this, python isn't finding those packages when trying to use them.

I thought there might be some weird dependency issue causing the need/desire from pip to reinstall them, so I tried to clean up the requirements. This doesn't seem to have made a change, so I'm trying to force --no-deps when installing dcpy in the build image. Going to run a test build to see if this resolves issue

Issue resolved now

damonmcc commented 2 months ago

was it because that failed build was run on a branch that's one commit behind main? and that one commit has changes to packages?

seems like nightly builds on main haven't had this issue, but definitely like any amount of package/install cleanup! just wondering why other builds have worked

fvankrieken commented 2 months ago

Ah maybe you're right. I still think it's nice to keep --no-deps, just make sure that nothing is actually being installed, just making the link to the dcpy folder