search

NYCPlanning / data-engineering

Primary repository for NYC DCP's Data Engineering team
14 stars 0 forks source link

add gdal to build image requirements #760

Closed fvankrieken closed 2 months ago

fvankrieken commented 2 months ago

Fix's @alexrichey issue of no gdal in the build containers. They do currently install dcpy's reqs in addition to their own req.txts, but I had to take gdal out of dcpy's reqs for some weirdness - to get this install working, I use piptools to compile dcpy's reqs using our constraints.txt. However, this fails if gdal binary isn't installed (if we did it outside of the build images before building them in an action), and for some reason hangs indefinitely when done as part of the docker image build (3+ hours). Simple enough to just have all dcpy reqs defined except gdal, and have the build images explicitly install it. Just weird

fvankrieken commented 2 months ago

@alexrichey I published images from this branch, so you want to rerun one of your failed jobs to make sure? Don't quite see how it couldn't be fixed, but just to be sure