search

NYCPlanning / data-engineering

Primary repository for NYC DCP's Data Engineering team
14 stars 0 forks source link

fix typo in overly-eager dev tag deletion #811

Closed fvankrieken closed 2 weeks ago

fvankrieken commented 2 weeks ago

"dev" image tags created in PRs with changes to python, docker, etc are deleted each week in a recurring job, IF their branch no longer exists.

At least that was intended. To avoid potential collisions with real tags, all dev image tags begin with "dev-". So for this branch, there would be images "build-base:dev-fvk-docker-cleanup". However, cleanup logic was comparing this tag name to JUST the branch name, and since "dev-fvk-docker-cleanup" is not an existing branch, the tag was being deleted everytime.

fvankrieken commented 2 weeks ago

mypy helped me not introduce another bug. Flaky tests now failing due to socrata - I thought I had removed them, I'll check those out in another PR