search

NYCPlanning / data-engineering

Primary repository for NYC DCP's Data Engineering team
23 stars 0 forks source link

Compile python requirements #937

Closed fvankrieken closed 4 months ago

fvankrieken commented 4 months ago

Automated changes by create-pull-request GitHub action

fvankrieken commented 4 months ago

Breaking change from numpy 2.0.0!

https://github.com/NYCPlanning/data-engineering/actions/runs/9627004556/job/26553697935#step:6:870

It is based on string representation of an error message that we generate. Seems that using a dict within a format string now specifies type.

Numpy 2.0.0 seems cool. Happy to wait and pin to older if we feel that a x.0.0 feels slightly risky, but I would be down to just upgrade.

alexrichey commented 4 months ago

@fvankrieken We should probably just cast to the python int in the failing case. Happy to make that change, if you're not already on it.

All for upgrading, otherwise.

damonmcc commented 4 months ago

would love to upgrade as well

fvankrieken commented 4 months ago

@fvankrieken We should probably just cast to the python int in the failing case. Happy to make that change, if you're not already on it.

All for upgrading, otherwise.

All yours 🙂

alexrichey commented 4 months ago

Fix here (created a new branch/PR so it wouldn't be overwritten)