NYCPlanning / db-colp

City Owned and Leased Properties Database (COLP)
0 stars 0 forks source link

Split export and upload steps #194

Closed SashaWeinstein closed 2 years ago

SashaWeinstein commented 2 years ago

I just accidentally uploaded my local build to the latest folder on edm-publishing because I didn't realize the export and upload steps were combined. These steps should be split and upload shouldn't overwrite latest on default. We made this same change to pluto and I think it was a good improvement

AmandaDoyle commented 2 years ago

Yes - let's go ahead and make this improvement to avoid this in the future.

SashaWeinstein commented 2 years ago

@AmandaDoyle I think it would be good to move COLP in line with other data products and upload to folders named after the branch the code is run from, and have our typical date+latest folders inside these branch folders. I want to ask before implementing this change though