search

NYCPlanning / db-cpdb

Capital Projects Database
https://nycplanning.github.io/db-cpdb
0 stars 0 forks source link

117 open data export #118

Closed caseysmithpgh closed 2 years ago

caseysmithpgh commented 2 years ago

A point of uncertainty in the creation of the spatial open data files:

Both spatial opendata tables reference tables that are created in the export step, specifically dcp_attributes_pts, dcp_attributes_poly, and cpdb_projects_combined. I suspect this will cause an issue because these referenced tables will not have been created (as they are all produced via the export step). Proposed refactor involves recreating the creation of these fields (geom, totalspend, maxdate, mindate, typecategory) in the same way they are created in the above mentioned tables rather than referencing those tables directly.

mbh329 commented 2 years ago

Not sure I understand your comment in the PR, do you want to roll over and discuss?

mbh329 commented 2 years ago

I tagged Amanda as a reviewer as well