117 open data export - Githubissues

NYCPlanning / db-cpdb

Capital Projects Database

https://nycplanning.github.io/db-cpdb

0 stars 0 forks source link

117 open data export #122

Closed caseysmithpgh closed 2 years ago

caseysmithpgh commented 2 years ago

Here you'll find I updated the syntax to fit SELECT INTO approach. All row counts seem to align on my local run.

mbh329 commented 2 years ago

Check order of columns in export:

[x] cpdb_opendata_commitments
[x] cpdb_opendata_projects
[x] cpdb_opendata_projects_pts
[x] cpdb_opendata_projects_poly

mbh329 commented 2 years ago

In regards to column order, all the files look good to me. I also took a look at the % of records that were mapped (projects_poly + projects_pts/total projects) and the numbers are consistent (~40% of projects successfully mapped) with what we have seen in the past. will do a couple more spot checks but think this is good to go

mbh329 commented 2 years ago

This looks great! I went a little crazy with the checks and tested the github action on the feature branch and the outputs look good and are succesfully uploaded to DO! Great job @caseysmithpgh, this is ready to be merged in. You do have a merge conflict atm because there were some recent merges into this file on our end so you will have to deal with those before merging