search

NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

bldg_class values for bis records are weird #472

Closed AmandaDoyle closed 3 years ago

levysamu commented 3 years ago

Building Class has a bunch of unexpected values. Of the post-2010 records, almost all of them have numbers in there instead of a building description. image

AmandaDoyle commented 3 years ago

buildingclass field is showing proposedzoningsqft value

SELECT COUNT(*) FROM dob_jobapplications where proposedzoningsqft = buildingclass; Equals 245674, which is the total number of records in the file

AmandaDoyle commented 3 years ago

@SPTKL My pull request didn't solve this issue. I might need your help

SPTKL commented 3 years ago

@AmandaDoyle we would need to change to current date with the right data https://github.com/NYCPlanning/db-developments/blob/main/version.env#L3

AmandaDoyle commented 3 years ago

Thanks for pointing me in the right direction. I'll look into this.

AmandaDoyle commented 3 years ago

Okay, I'm confused. Is the issue rooted in the when we pulled the source data? So we need to use updated source data (08/10) to capture the building class information? I see that all version of dob_jobapplicaiton in data library have proposedzoningsqft in the building class columns.