Debug DevDB - Githubissues

NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database

https://nycplanning.github.io/db-developments

8 stars 2 forks source link

Debug DevDB #486

Closed AmandaDoyle closed 2 years ago

AmandaDoyle commented 2 years ago

Noticed devdb.csv was empty and as were many other output files created off of the 485-runner-down branch.
I started digging into the GitHub Action log. I think the issue stems from this error: psql:sql/_hny.sql:431: ERROR: invalid input syntax for integer: "B00558782"
"B00558782" is a unique ID in dob_now_applications
I think casting both job numbers to text in this line will resolve the issue.

td928 commented 2 years ago

look into this and noticing that seems the changes proposed were made on a feature branch and then removed again by @SashaWeinstein later. Thinking this is working now and should be okay to close? @AmandaDoyle

td928 commented 2 years ago

Took a closer look at Sasha's PR for million bins and seems like it addressed this issue. Please let me know that is a misread of the PR.

AmandaDoyle commented 2 years ago

Yes, @td928 this has been addressed. We need to get better at closing addressed issues.