search

NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

Vestigal `qaqc_geo.sql` #517

Closed SashaWeinstein closed 2 years ago

SashaWeinstein commented 2 years ago

There are two versions of this file, one in sql/ and one in sql/qaqc/. They seem to do the same thing, with the version in sql/ having a couple more columns. The bash script points to the one in sql/qaqc/, I think the other one can come out? Curious what others think

td928 commented 2 years ago

agree. In a similar vein, _init.sql is also depreciated and now moves to two distinct steps in sql/now/_init.sql and sql/bis/_init.sql

SashaWeinstein commented 2 years ago

Interesting. Think clearing up the init redundancy might be harder though as _init.sql is called, whereas sql/qaqc_geo.sql is never even called

td928 commented 2 years ago

nvm I made a mistake it is not a real redundancy.

td928 commented 2 years ago

529