Closed abrieff closed 2 years ago
Code makes sense to me at first glance. Not sure what you mean by question 1. For question 2 I think it does make sense to only store records with flags in the intermediate table, it means qaqc_app
will have nulls instead of zeros for jobs that pass checks right?
classa_net_mismatch
so makes sense for them to come from the same fileI think making the intermediate table only have records with flags requires an entirely different implementation to be extendable (otherwise how will manage that for multiple different columns with different checks) and would probably recommend leaving it as is for consistency/simplicity, if you disagree maybe we can chat about it
Ok word this makes me think I don't understand yet. Shouldn't FINAL_devDB
and FINAL_qaqc
have the same list of job numbers?
Adds in check for classa_net mismatch. Two things I wasn't sure about: