NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

dob_geocoded_results incorrectly joined #539

Closed td928 closed 2 years ago

td928 commented 2 years ago

A downstream issue spotted in the qaqc app with the bbl leads to finding out the dob_geocoded_results did not get joined correctly. This brought up a number issues with the current devdb design in both the data_sync step (specifically with the library_archive_version function #506) and also the _geo.sql where the join happens with uid which is created from the row number of the source data.