22Q2 Final Review feedbacks

[td928]

One stone for three birds #544 #543 and #542. One reviewer required 🐠

544

This is probably the most but also the one without any work in this PR! The update happened in the data library side where there are two new dob_cofos happened between two branches. First one is adding the second half of cofos to the 20211026 version which created the new 20220101 version. Then the 20220101 version is used to concat with data from another email to create the latest 20220819 version. After this process, it is confirmed all the 459 records flagged by EDM now has their complete year filled out.

543

This is tricker issue than initially anticipated. As you can see the files changed, I comment out the queries producing the census units count because the logics are fundamentally flawed and need major rework to produce. Also according to Sam, we might need to do something quite different for census units for the future and we got the green light to exclude those fields for this update and revisit this in the future.

542

Simplest work which involves a simple type casting in the final output table for the shapefiles. The attribute at question here is classa_hnyaff. I do think this would be helpful with extra set of eyes if someone else could download the shapefiles and open them in gis to see it is indeed now numeric.

[mbh329]

@td928 why did the manual corrections table change?

[td928]

@td928 why did the manual corrections table change?

Good question. Sam made four new corrections and I included in this as well.

[mbh329]

@td928 Was a pull request opened on the data library side for the dob_cofos?

[mbh329]

The certificate of occupancy looks good now (the records I checked yesterday are now in the latest dob_cofo's) and the classa_HNY column is an interger when I opened the shapefile in QGIS