search

NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

Job Inactive Status Manual Corrections #556

Closed td928 closed 2 years ago

td928 commented 2 years ago

555 1️⃣ reviewer

overview

To address the issue with inactive status from potential problematic date lastupdt, we are making a one-off fix for the records are impacted by the current logic. For the future, it is likely we modify the process which we flag for inactive stalled record to not have this issue again.

Review this PR

I would recommend to ingest the manual corrections and rebuild DevDB. Then simply query for these six records from the final table for those jobs mentioned in the issue #555 to check if their job_inactive flags are indeed corrected to NULL.

mbh329 commented 2 years ago

ran the dataloading and build steps and checked some records in final_devdb to make sure they were applied. lgtm