Closed td928 closed 1 year ago
Running this now. Where is the code to take the status date and job status from the earliest date?
I looked at both records you mentioned in the description and none of the of the job filing numbers end in 'I1' so I don't see how they would be affected?
@td928 It would be good to get some clarification on the issue
I looked at both records you mentioned in the description and none of the of the job filing numbers end in 'I1' so I don't see how they would be affected?
so the I1
is taken out of the unique identifier (job_number) after the filter is applied.
I saw those two records in the final_devdb table and they are included. This looks good to me, kinda crazy how many records we are still getting from BIS for the those permitted in 2022Q2
566 for more details
the change is straightforward in the
sql/_status_q.sql
where the dob_now_permits records are no longer filtered down to theI1
but to include all types and then taking thedate_permitted
from the earliest record.Review
I use the two examples housing cited as evidence for no correctly assigned permits
M00522293
andM00558120
and located them in thefinal_devdb
to confirm whether their status anddate_permitted
correctly reflect the permits. One thing to pay attention to is this again is pointing to themain
branch since we want to keep the production consistent since last time. Manual corrections table is updated again because housing has found a few things to correct in the interim.