NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

Add `cdtaname2020` to intermediate devdb tables and outputs #573

Closed mbh329 closed 1 year ago

mbh329 commented 1 year ago

Addresses issue #571.

@croswell81 and @levysamu wanted to add the CDTA Name 2020 column to the final devdb outputs. This PR addresses this and adds the new column to the final output and corresponding intermediate tables.

To test this new change, I built devdb locally and checked that the column was in the required tables.

mbh329 commented 1 year ago

Additionally, I tested the build with the additional column here

SashaWeinstein commented 1 year ago

To confirm my understanding, this was branched off main as it's an enhancement to the publishing process for 22Q2 and is meant to clean up the aggregation on a version of devDB that's already been through manual review. This is in contrast to issues in the "22Q2 Enhancements" which are enhancements for the next build

td928 commented 1 year ago

To confirm my understanding, this was branched off main as it's an enhancement to the publishing process for 22Q2 and is meant to clean up the aggregation on a version of devDB that's already been through manual review. This is in contrast to issues in the "22Q2 Enhancements" which are enhancements for the next build

that's exactly right