search

NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

update manual corrections #583

Closed td928 closed 1 year ago

td928 commented 1 year ago

582 one reviewer 🌞

Per housing request to rerun the build for 22Q2 with version on 9/22/2022

review tips

What I did to review is pretty simple I went to the github action output and look at the corrections_applied.csv to see if the new additional corrections housing want to include is in it. For the few I spotted checked seems good.

mbh329 commented 1 year ago

I checked the corrections_applied.csv and the housing.csv for the new values that same had pointed out, they look good to me

SashaWeinstein commented 1 year ago

Te I'm curious how did the find the errors in the manual corrections file and how did you fix them?

td928 commented 1 year ago

Te I'm curious how did the find the errors in the manual corrections file and how did you fix them?

Good questions. I run a batch and found some of those corrections did not make into the applied sheet. Then I realize the field names point to is just wrong. I then asked Housing to fix it on their end and rerun.