search

NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

Apply filter to A2 jobs #585

Closed SashaWeinstein closed 1 year ago

SashaWeinstein commented 1 year ago

Small PR, just for Te to review 🥕 After our conversation with Sam we realized we forgot to filter the A2 jobs. Sam said he expected 20k A2 jobs that change num of units, and this code produces around 16k on my machine

td928 commented 1 year ago

@SashaWeinstein hey Sasha trying to run this locally to do some testing. Which version of DO job application I should use to run it? I just tried the 0925 version and it did not have the new columns

SashaWeinstein commented 1 year ago

The version.env has a DOB_DATA_DATE that points to the job_applications with the A2 records

SashaWeinstein commented 1 year ago

@td928 made the change you suggested. Still end up with 15.8k A2 jobs that change num of units