NYCPlanning / db-developments

🏠 🏘️ 🏗️ Developments Database
https://nycplanning.github.io/db-developments
8 stars 2 forks source link

Reduce number of jobs getting geocoded #610

Closed td928 closed 1 year ago

td928 commented 1 year ago

609 one reviewer required

Hey all I did this work awhile ago but somehow forgot to create PR and ask for it to be reviewed. But since we were talking about building devdb this morning which made me wonder if data sync was able to run successfully recently. It turns out they weren't.

This was the issue I spotted few weeks ago since the A2 jobs inclusion making geocoding work so much heavier and the step would fail. I did this temporary patch to reduce the number of total jobs to be geocoded but see #609 writeup on my thoughts on this for the future. Some testing suggest that this patch worked.

damonmcc commented 1 year ago

@mbh329 @AmandaDoyle

I took a shot at adding the requested comment. I added it at the top of the query since it's a bit risky adding comments to the middle of a python SQL query text block lol