NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)
MIT License
0 stars 0 forks source link

QOL review - PUMA file #167

Open AmandaDoyle opened 2 years ago

AmandaDoyle commented 2 years ago
SashaWeinstein commented 2 years ago

Fixed column labels, waiting for new indicators to get approved so I can add those too

SashaWeinstein commented 2 years ago

I also want to flag that I moved access to open space percent after access to open space. Don't know if it matters but it came up during refactor and I assumed that percentages come after

SashaWeinstein commented 2 years ago

I wrote about this on teams but I want to put it here for posterity. The pedestrian hospital column names issue was due to there being two version of the pedestrian_hospitalizations function. What happened is that the pedestrian hospitalizations was written first in the pedestrian_hospitalizations.py file. But then I realized assaults was similar enough that they should share a file. so the final pedestrian hospitalizations function that I was editing was in safety_ped_aslt_hospitalizations.py. But the old .py file wasn't deleted on the feature branch and the deletion wasn't merged into dev which is very bad. I should have caught this but also it should have been caught on review. Letting outdated code sit around is not good and something we need to be more vigilant of