Open AmandaDoyle opened 2 years ago
Fixed column labels, waiting for new indicators to get approved so I can add those too
I also want to flag that I moved access to open space percent after access to open space. Don't know if it matters but it came up during refactor and I assumed that percentages come after
I wrote about this on teams but I want to put it here for posterity. The pedestrian hospital column names issue was due to there being two version of the pedestrian_hospitalizations
function. What happened is that the pedestrian hospitalizations was written first in the pedestrian_hospitalizations.py
file. But then I realized assaults was similar enough that they should share a file. so the final pedestrian hospitalizations function that I was editing was in safety_ped_aslt_hospitalizations.py
. But the old .py file wasn't deleted on the feature branch and the deletion wasn't merged into dev which is very bad.
I should have caught this but also it should have been caught on review. Letting outdated code sit around is not good and something we need to be more vigilant of
[x]
safety_ped_hospital_per100k
- rename tosafety_pedhospital
[x] Rename
pct_access_openspace
toaccess_openspace_pct
[x] COVID death fields need to be renamed to match convention.
health_covid19deaths
is what was spec'd out in issue, sototal_covid_death
should behealth_covid19deaths
,total_covid_death_anh
should behealth_covid19deaths_anh
, etc.[x] COVID death fields need to be reworked. What's spec'd out is deaths/100,000 residents not total number of deaths, which is what we're reporting. Use 2020 total population at PUMA level to calculate the rate. We have this data from the Race and Hispanic origin in the Demographic category. Use the total population for that race when calculating rate for a race.
[x] Missing fields for the following indicators:
Public Safety: Assault
Public Safety: Pedestrian Injury
Access to transit: ADA
Access to transit: Subway and SBS