151 rename housing production attributes

NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)

MIT License

0 stars 0 forks source link

151 rename housing production attributes #171

Closed td928 closed 2 years ago

td928 commented 2 years ago

Overview

All output names updated to follow new conventions for both the change in units indicator and also the affordable units from HPD indicator.

Refactoring change_in_units

Three functions in change in units reduced to one for better design and reduce about 40 lines of codes.

HPD affordable script

The renaming for columns take place in the final transformation. A simple approach of replacing the appropriate strings was taken.

Output files

all output saved to internal review

td928 commented 2 years ago

Hey @AmandaDoyle @SashaWeinstein Thank you both for your comments. I believe the total units 2010 has been addressed. Also the new commit swapped the position now it is units_eli etc.Please checkout the new output files when you have a chance!

SashaWeinstein commented 2 years ago

This looks to be just code to rename an existing column, does it also add it to the final output?