search

NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)
MIT License
0 stars 0 forks source link

88 access broadband #194

Closed td928 closed 2 years ago

td928 commented 2 years ago

Overview

Use EDDT data shared by the Erica

load data

bulk of the work is actually taking place in the load_clean_source_data where the column names are renamed with a few dictionaries. It is important to note the sequence of the functions being run is relevant here because the race replacement must be the first.

access_broadband

this part of the function is simply pulling the right geography rows from the spreadsheet.

SashaWeinstein commented 2 years ago

This all looks good except that the column names aren't intuitive to me. I see from the issue that we are to return Total households With a computer With broadband internet

"Access_broadband_households" to me reads like households with broadband internet. If we've already finalized then maybe it's not worth changing but could cause issues later on

SashaWeinstein commented 2 years ago

lol wonderful Te pushed those changes the at the same time I made my comment

td928 commented 2 years ago

Thanks! To @mbh329 @SashaWeinstein comment, I incorporated those new functions. The new output for puma looks good as well. I was hesitant about the column naming as well except they are specified quite explicitly in the issue #88. @AmandaDoyle is the thinking here that we will be able to explain it in the data dictionary?

td928 commented 2 years ago

okay. New naming conventions updated. All output files were updated. @SashaWeinstein @AmandaDoyle @mbh329