NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)
MIT License
0 stars 0 forks source link

Add Access to Transit: Car Commute for QOL Outputs #198

Closed mbh329 closed 2 years ago

mbh329 commented 2 years ago

access_transit_car.py

Pretty simple stuff and takes a lot of logic from code that has already been written. One thing worth noting is that this script joins two xlsx sheets (08-12 ACS PUMS + 15-19 ACS PUMS) to create one output with unique column headers with the year the data reflects. This is different from some of the other work we have done with PUMS where there are two separate outputs for each set of years. Another thing worth noting is that in the original xlsx files the Wk16p columns indicate a denominator for the calculation Erica did but we don't add the age_ suffix in the renaming per AD & Erica.

The column renaming got me in a tizzy but the columns look good, could probably find a better way to do that.

resources/ACS_PUMS

We might want to talk about where these xlsx files are stored in the repo - I hastily created this ACS PUMS folder but maybe we want to keep it somewhere else....something to think about but also maybe not.

mbh329 commented 2 years ago

Thanks Sasha! I can move the chucks of code into utils and create the helper functions I think might be useful to ingest erica's data

td928 commented 2 years ago

Hey Max is the understanding that this pull request won't deal with the util refactoring and it would be handled in another work addressed to the new issue #200? In that case I think it should be ready for approval.

mbh329 commented 2 years ago

@td928 Yes, that is correct.