Test-driven development for "count" token refactor
We need to update all EDDT indicators to include "_count" in column labels for data points of counts. Previously the convention was that if pct was not specified in the column label it was assumed to be a count. However to make it easier for OSE to parse out tokens from column names the "_count" token will be introduced.
New test for correct tokens
One new test test_count_pct_tokens_present was written. This checks that all columns have "count" or "pct" substring in the column label. After writing this I realized that heat vulnerability is neither a count nor a pct but rather an index. We can remove it from this test or specify it as an "index" and make that an acceptable token along with "count" and "pct"
Refactor tests
I changed the design so that accessors are called once per test file which should improve run times
Testing yml
I changed the testing yml to only run the existing tests as the new ones are supposed to fail and thus there is no reason to run them in an action.
Side note: some indicators already pass
Educational outcomes and access to subway and ADA transit only report percentages so these already pass the new tests.
Test-driven development for "count" token refactor
We need to update all EDDT indicators to include "_count" in column labels for data points of counts. Previously the convention was that if pct was not specified in the column label it was assumed to be a count. However to make it easier for OSE to parse out tokens from column names the "_count" token will be introduced.
New test for correct tokens
One new test
test_count_pct_tokens_presentwas written. This checks that all columns have "count" or "pct" substring in the column label. After writing this I realized that heat vulnerability is neither a count nor a pct but rather an index. We can remove it from this test or specify it as an "index" and make that an acceptable token along with "count" and "pct"Refactor tests
I changed the design so that accessors are called once per test file which should improve run times
Testing yml
I changed the testing yml to only run the existing tests as the new ones are supposed to fail and thus there is no reason to run them in an action.
Side note: some indicators already pass
Educational outcomes and access to subway and ADA transit only report percentages so these already pass the new tests.