search

NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)
MIT License
0 stars 0 forks source link

221 add count token housing security #224

Closed td928 closed 2 years ago

td928 commented 2 years ago

WIP branch and pull request for add _count to housing security and quality. Sharing the progress on this because we are near deadline and someone might need to pick up this work.

SashaWeinstein commented 2 years ago

Sasha's contribution on wednesday afternoon

Hey I want to give update on my work.

Existing Indicators conform to our conventions

All indicators we have code to produce have columns with a measure token and return a dataframe with the correct index.

Updates to testing action

I changed the testing action to test for correct measure token (count, pct, etc) and only test housing security. This will continuously change as we work through different categories. Maybe would have been better to start new action but this way was easier and will force us all to think about what we want to test which is good.

Test evictions by city marshals

This indicator requires geosupport to run, so we can only run it in devcontainer and on github actions. I added a way to conditionally add this indicator to our list of accessors with this block 

def get_accessors():
    try:
        Geosupport()
        return [count_residential_evictions]  # + accessors
    except GeosupportError:
        return accessors

It works which is cool, and will allow us to test/export residential evictions from github actions

Test housing security only

I housing_security parameter in code that loads accessors for the tests, this is temporary and should come out after we know tests pass

Next just wait for last housing security indicators to come in march 4th population spreadsheet

SashaWeinstein commented 2 years ago

In these last commits I add in the new indicators and clean up some unused imports/print statements. I also comment out a block of unused code in load_aggregated.py. Figured this was ok because it needs a refactor anyways

SashaWeinstein commented 2 years ago

@td928 I can't assign you as reviewer because you opened this PR, but you should be reviewer

td928 commented 2 years ago

@td928 I can't assign you as reviewer because you opened this PR, but you should be reviewer

lol about this. I also could not approve because I opened it.

SashaWeinstein commented 2 years ago

@td928 I can't assign you as reviewer because you opened this PR, but you should be reviewer

lol about this. I also could not approve because I opened it.

lol shoot. can you review? or do you want to just leave comments in conversation?

td928 commented 2 years ago

yeah I will review and leave comments. But I just can't approve because it is my PR.

SashaWeinstein commented 2 years ago

Hey @AmandaDoyle, @mbh329 I think this is big enough to need two reviewers? Once it's approved by one of you I can run the housing security export from dev