search

NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)
MIT License
0 stars 0 forks source link

main and feature branch export #297

Closed td928 closed 2 years ago

td928 commented 2 years ago

to test the exporting fully on DO. Modifying the workflow to check if the branch Actions is being run on is main or feature branch.

SashaWeinstein commented 2 years ago

Awesome! Going to test this echoing the spaces variable to the console to check that it's correctly assigned. My only other comment is whether we want to echo all variables passed to the export function in that way

SashaWeinstein commented 2 years ago

Another comment here is that facDB and pluto get the branch name in bash instead of the github workflow. Might be nicer to use that approach instead

SashaWeinstein commented 2 years ago

Pushed a commit to fix syntax. I also don't remember why we have export census does but I don't know if we need it? Maybe it could come out in this PR

SashaWeinstein commented 2 years ago

Maybe export category and census can be two jobs in one build new combined build action?

td928 commented 2 years ago

Another comment here is that facDB and pluto get the branch name in bash instead of the github workflow. Might be nicer to use that approach instead

ah this is what I was looking for. Let me know if the most recent commit makes sense.

SashaWeinstein commented 2 years ago

Ok I also see that some actions were run from 293-not-latest-from-DO such as this one https://github.com/NYCPlanning/db-equitable-development-tool/actions/runs/2927282419. I think we should also stop running on pushes to the .yml, that's not a good design. I think that can change can come in this PR

td928 commented 2 years ago

made another change on the metadata.py I think I got to the issue with str vs. int. And also got rid of the run on push in yml. Let me know if looks good on your end to merge. Thanks! @SashaWeinstein