fix dev container - Githubissues

NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)

MIT License

0 stars 0 forks source link

fix dev container #322

Closed damonmcc closed 1 year ago

damonmcc commented 1 year ago

motivations

per issues in #320 and wider-scale improvements in #321, it may be nice to first fix the broken dev container
likely due to changes from #319

changes

undo removal of R install in setup_build_env.sh
- since subsequent python package installs need it (even if the packages aren't currently used in scripts we run)
add a github test to build the dev container in CI
skip the ssh-add step of the dev container build during the test using a github default environment variable which is always true

notes

new dev container test fails quickly (1m 22s)

fvankrieken commented 1 year ago

So this test failing is a funny one - we require an ssh key to build locally. There isn't one for github to grab from its artifacts/secrets. Not sure if that's something that really needs to be tested, but then we'd have to figure out how to run a custom dev container build without github ssh integration for testing