NYCPlanning / db-facilities-old

This repo contains all the scripts used to build the City Planning Facilities Database (FacDB). Please note this database and its build and maintenance processes are still in active development.
https://capitalplanning.nyc.gov/facilities
5 stars 3 forks source link

Geocode to centerline if geocoding to the lot fails #287

Open lseirup opened 5 years ago

lseirup commented 5 years ago

Description

Some records have addresses that are failing the second part of the Geosupport 1B call - they geocode to the centerline (function 1E), but not to a BBL (function 1A).

For school bus depots, examples include 1326 Ralph Avenue, 22 Bay Street, and 2037 Eastern Parkway, all in Brooklyn.

We need to talk with GRU and set up an error reporting procedure for these records.

SPTKL commented 5 years ago

Hi Lynn, if an address is failing function 1B, it won't get a lon/lat return at all (this is how the python-geosupport package set up).

The reason why you are seeing points at the center line is because for records that didn't geocode (without lon lat returned from geosupport), we backfilled the geometry with spatial data from the source data

this also explains why you are seeing 1326 Ralph Avenue, 22 Bay Street, and 2037 Eastern Parkway geocoded to the centerline