NYCPlanning / db-factfinder

data ETL for population fact finder (decennial + acs)
https://nycplanning.github.io/db-factfinder/factfinder/
MIT License
2 stars 3 forks source link

For aggregated geography we should calculate the P and Z for poverty vars #166

Closed SPTKL closed 3 years ago

SPTKL commented 3 years ago

this should fix the remaining poverty variables mentioned in https://github.com/NYCPlanning/db-factfinder/issues/130#issuecomment-882735352 https://github.com/NYCPlanning/db-factfinder/issues/72

mgraber commented 3 years ago

@SPTKL I was working on this, too. Just reached out to Erica to confirm that this should be the logic. If you already did, can you point me to it?

SPTKL commented 3 years ago

@SPTKL I was working on this, too. Just reached out to Erica to confirm that this should be the logic. If you already did, can you point me to it?

I haven't reached out, but based on our logic for profile only variables for non-aggregate geographies, we take p from {{ variable_name }}PM and z from {{ variable_name }}PZ but for poverty variables, they come from different variables instead of {{ variable_name }}PM and {{ variable_name }}PZ.

but for aggregated geographies, we should be calculating p and z instead of taking them from census variables I confirm that the numbers match up to Erica's calculation for NTA/CD20