NYCPlanning / db-knownprojects

KPDB: A compilation of prospective residential development projects from various sources, with rough projections of new unit counts
https://nycplanning.github.io/db-knownprojects
0 stars 0 forks source link

adding units_gross as a second option to get units_net values populated #396

Closed AmandaDoyle closed 1 year ago

AmandaDoyle commented 1 year ago

395

mbh329 commented 1 year ago

Approved. See successful build here and latest output here for reference.

mbh329 commented 1 year ago

Old version of KPDB had units_net=0 for DOB records not assigned to a cluster.

Screenshot 2023-03-23 at 12 28 39 PM
mbh329 commented 1 year ago

New output successfully populates these records with the units_net

Screenshot 2023-03-23 at 12 30 59 PM
mbh329 commented 1 year ago

Hold off on merging, I spoke with sam and there is another issue:

DOB records that are active (status 1,2,3) should have values in within_5_years = units_net * prop_within_5_years`

AmandaDoyle commented 1 year ago

Hold off on merging, I spoke with sam and there is another issue: DOB records that are active (status 1,2,3) should have values in within_5_years = units_net * prop_within_5_years`

Can't this be a separate issue and PR?

AmandaDoyle commented 1 year ago

@mbh329 added logic to address issue #397

mbh329 commented 1 year ago

It totally could have been, just wanted to make you were aware of the update from sam

mbh329 commented 1 year ago

LGTM.

Screenshot 2023-03-23 at 2 54 36 PM