search

NYCPlanning / db-knownprojects

KPDB: A compilation of prospective residential development projects from various sources, with rough projections of new unit counts
https://nycplanning.github.io/db-knownprojects
0 stars 0 forks source link

special cases to parse borough from record_id #403

Closed fvankrieken closed 1 year ago

fvankrieken commented 1 year ago

I moved the call to get_boro upstream to simplify the kpdb creation query a little. It checks whether borough is null, and then based on source parses borough from the record_id.

We could theoretically do this "first" (parse borough from record id, if null then call get_boro. But as you know I don't like that function to begin with, so I think this is fine for now

fvankrieken commented 1 year ago

After this, 9 records still need boro

source record_id record_name
HPD Projected Closings 3d3a2dd3c6ec864f5e18cec8e03eb2a7 784 COURTLANDT AVENUE  
HPD Projected Closings ff4c3b3e09d4c3a0d527a5c7988242d0 1559 PROSPECT PLACE  
HPD RFPs 0ce4a0321f576ad9b397dec9358f255f MWBE Site B - 1921 Atlantic Ave  
HPD RFPs 100c52f92560bc161659f99b08340e9f 97 West 169 St  
HPD RFPs 1db4d18c803723face138966e70095d8 NYCHA West Brighton RFP  
HPD RFPs 473c582483789bb07b5837ecdb746ae4 Bedford-Stuyvesant Community Wealth and Wellness RFP (Fulton-Saratoga)  
HPD RFPs 862c3d3640912f5ec6561375a03449ef Hunters Point F + G  
HPD RFPs 9bd199e88bb8dd9b128d0d3c71b520b5 Hunters Point F + G  
HPD RFPs defae821da6ac0b1a7610be5c7d5f484 SustaiNYC (E. 111th Street)  
AmandaDoyle commented 1 year ago

After this, 9 records still need boro

source record_id record_name borough
HPD Projected Closings 3d3a2dd3c6ec864f5e18cec8e03eb2a7 784 COURTLANDT AVENUE  The Bronx
HPD Projected Closings ff4c3b3e09d4c3a0d527a5c7988242d0 1559 PROSPECT PLACE  Brooklyn
HPD RFPs 0ce4a0321f576ad9b397dec9358f255f MWBE Site B - 1921 Atlantic Ave  Brooklyn
HPD RFPs 100c52f92560bc161659f99b08340e9f 97 West 169 St  The Bronx
HPD RFPs 1db4d18c803723face138966e70095d8 NYCHA West Brighton RFP  Brooklyn
HPD RFPs 473c582483789bb07b5837ecdb746ae4 Bedford-Stuyvesant Community Wealth and Wellness RFP (Fulton-Saratoga)  Brooklyn
HPD RFPs 862c3d3640912f5ec6561375a03449ef Hunters Point F + G  Queens
HPD RFPs 9bd199e88bb8dd9b128d0d3c71b520b5 Hunters Point F + G  Queens
HPD RFPs defae821da6ac0b1a7610be5c7d5f484 SustaiNYC (E. 111th Street)  Manhattan

@levysamu Can you confirm that the boroughs that I assigned to each project above is correct? The borough value will need to be assigned to these projects via a manual correction.

fvankrieken commented 1 year ago

Part of #399