NYCPlanning / db-pluto

🔭 PLUTO and MapPLUTO
https://nycplanning.github.io/db-pluto
39 stars 13 forks source link

[build] version: Major: 23v1 #433

Closed AmandaDoyle closed 1 year ago

AmandaDoyle commented 1 year ago

Update version name

PLUTO now uses version numbering YYvMAJOR.MINOR

  1. YY for the last two digits of the release year
  2. MAJOR version for using the latest versions of all input data
  3. MINOR version for using the latest versions of particular input data

Major Release: To initiate a major release, you must change the VERSION and VERSION_PREV. All other variables can remain unchanged and will default to latest in the dataloading step.

Minor Release: To initiate a minor release, you must change the VERSION and VERSION_PREV. In addition, you are required to hold the following variables constant with the last major release of PLUTO (you can reference the source_data_version table):

Manual Updates

Updated 2x a year typically in June and December

Automated Updates

Open data automated pull

Check here to see the latest run

DOF Automated Pull and Number of Buildings

Updated with Quarterly updates (check here)

Updated with Zoning Taxlots (check here for latest run). Note: for a minor release of PLUTO, these will be the only datasets that will be updated.

Never Updated (Safe to ignore)

Update QAQC App

- [ ] update data-engineering-qaqc version_comparison_report in src/pluto/pluto.py with version of pluto build (must be updated with every version of pluto [here] (https://github.com/NYCPlanning/data-engineering-qaqc/blob/main/src/pluto/pluto.py))

PLUTO Improvements (corrections)

Build CI Runs

Comments

damonmcc commented 1 year ago

re builds failing on branch 23v1-dev

damonmcc commented 1 year ago

archive of 22v3.1 worked by using an input version of 22v3_1. started a build with underscore version notation

damonmcc commented 1 year ago

@AmandaDoyle build succeeded but use of QAQC for this new version number isn't possible until this new version number is explicitly listed in the app's code

will start on a fix for the QAQC app, but manual inspection of BCTCB2020 values related to issue #432 can be done on data in DO

primarily using existing relevant issue https://github.com/NYCPlanning/data-engineering-qaqc/issues/249

damonmcc commented 1 year ago

the QAQC app is now able to view this version of data, but it hasn't been run on main and CAMA data is still unavailable

started draft PR https://github.com/NYCPlanning/db-pluto/pull/437 to prepare for merge to/build on main

AmandaDoyle commented 1 year ago

AD Notes on PLUTO QAQC: 1) Use QAQC app to identify any anomalies. Use descriptions as guides. 2) See if BCTCB2020 being NULL is still an issue #432 3) Make sure research is being applied #434 and the updated process for applying research is working as expected #424 4)Make sure city council district values are not null and the "current" is being applied #430 5) Make sure condos have geometries #410

Once CAMA is released at the end of this week we'll want to kick off another build; ideally by the end of this week before updated PTS data is pulled in over the weekend.

damonmcc commented 1 year ago

having

a build on the dev branch is underway

damonmcc commented 1 year ago

added links to builds on dev and main branches to issue description