Closed damonmcc closed 1 year ago
A couple very minor questions, but looks good and I love it - I've been using set -e
locally to make getting my environment set up much more sane, and personally would love to make that our standard practice to avoid these silent failures
motivations
dof_dtm
started a deep dive into how it's importedchanges
set -e
to all bash scripts to exit if any command has a non-zero exit status-v ON_ERROR_STOP=1
to SQL queries in bash files to ensure they stop on errorsrun_sql_file
to run all sql files and stop on errorsdcp_zoning_taxlot
without using it and then renamingdcp_zoningtaxlots
todcp_zoning_taxlot
(butdcp_zoningtaxlots
table never exists)dcp_zoning_taxlot
ST_MakeValid
to preprocessing ofdof_dtm.geom
column to handle latest data (error in a build)config.sh
dof_dtm
source data due to data library failing to do sonotes
dof_dtm
have been added for potential future use. but ideally they're here for reference in a more long-term fix to the issue in data library (https://github.com/NYCPlanning/db-data-library/issues/381)