NYCPlanning / deprecated-labs-zap-api

Deprecated version of the ZAP API, see https://github.com/NYCPlanning/labs-zap-api
Other
5 stars 3 forks source link

Spatial downloads #112

Closed chriswhong closed 5 years ago

chriswhong commented 5 years ago

Adds two new endpoints under /projects:

Each takes the same query params as /projects (except for pagination), so the frontend implementation should be to build out a button that hyperlinks to the above endpoints, adding the same query params that are currently in effect in the ZAP Search filter view.

Because shapefile creation depends on ogr2ogr, this PR also adds a Dockerfile. This Dockerfile will be used by dokku to ensure that GDAL (and ogr2ogr) is available in the container this API will run in.

I tested this Dockerfile in a dummy dokku app and it worked, but I didn't test everything manually. We should take care to watch the deployment closely once this gets pushed.

TODO:

allthesignals commented 5 years ago

Closes https://github.com/NYCPlanning/labs-zap-search/issues/424

ghost commented 5 years ago

don't forget to rebase & squash before merging !!! and maybe for posterity edit the PR description to describe what it actually does now :)

allthesignals commented 5 years ago

This is really hard to setup for local development. Let's get some of these dependencies Dockerized so it's easier to setup fresh!

allthesignals commented 5 years ago

Two things:

allthesignals commented 5 years ago

@chriswhong blah, I need help: https://circleci.com/docs/2.0/building-docker-images/