NYCPlanning / deprecated-labs-zap-api

Deprecated version of the ZAP API, see https://github.com/NYCPlanning/labs-zap-api
Other
5 stars 3 forks source link

Project should move to "Reviewed" tab when rec submitted #218

Closed hannahkates closed 4 years ago

hannahkates commented 4 years ago

When an LUP submits their recommendation, we won't auto advance the milestone in CRM. However, the project should be categorized as "Reviewed" in the view.

We'll need to update the SQL queries so that:

(We also might need to update the logic on the show view's top-right box.)

allthesignals commented 4 years ago

See the computed property hearingsSubmittedOrWaived

andycochran commented 4 years ago

"Submit recommendation" button should disappear after rec has been submitted

I do not understand ^this title. If a recommendation has been submitted, the project should not show up on any tabs that have buttons. Perhaps the problem is that when a recommendation is submitted, the project is not getting its status changed. This can be addressed by us automating the advancement of the milestone when the recommendation is submitted OR by the tab logic accounting for where a recommendation has been submitted (putting it in the "Reviewed" tab regardless of the current milestone).

I will update the title and confirm the business logic with our partner.

andycochran commented 4 years ago

Confirmed that LUP milestones should not auto-advance. Issue title/description updated accordingly.