search

NYCPlanning / labs-applicantmaps

5 stars 5 forks source link

Upgrade Ember #521

Closed allthesignals closed 5 years ago

allthesignals commented 5 years ago

This PR upgrades ember, and includes some syntax changes plus removes the argument decorators that were causing numerous issues duuring upgrade (in genernal that package is not stable for upgrade paths and should be avoid ed until it matures a bit more. or, we move to typescript :) )

codecov[bot] commented 5 years ago

Codecov Report

Merging #521 into develop will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    85.83%   85.77%   -0.06%     
===========================================
  Files           69       69              
  Lines          967      963       -4     
===========================================
- Hits           830      826       -4     
  Misses         137      137
Impacted Files Coverage Δ
app/routes/projects/edit/index.js 0% <ø> (ø) :arrow_up:
app/controllers/projects/edit/steps/complete.js 100% <ø> (ø) :arrow_up:
app/routes/projects/edit.js 60% <ø> (ø) :arrow_up:
...oject-geometries/utils/canonical-geometry-reset.js 0% <ø> (ø) :arrow_up:
app/components/project-geometries/utils/button.js 100% <ø> (ø) :arrow_up:
app/controllers/projects/show.js 33.33% <ø> (ø) :arrow_up:
app/models/applicant-map.js 100% <ø> (ø) :arrow_up:
app/components/project-geometries.js 100% <ø> (ø) :arrow_up:
app/components/project-form.js 100% <ø> (ø) :arrow_up:
app/routes/projects/edit/map/edit.js 71.42% <ø> (ø) :arrow_up:
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a366519...cee8b9c. Read the comment docs.