NYCPlanning / labs-applicantmaps

5 stars 5 forks source link

App does not transpile for IE11 #532

Open allthesignals opened 5 years ago

allthesignals commented 5 years ago

For some reason, related to the issue outlined here, EmberJS is not transpiling some of the imported dependencies, including mapbox-gl-js, among others. These deps use things like arrow functions which are not supported in IE11.

Following the linked thread, I am able to get past some of the initial compatibility issues, but there are downstream problems that I can't quite debug:

image

I can't inspect these error messages, the IE11 debugger just tries to "open" them but nothing happens.

CeciliaCY commented 5 years ago

image

Having same issue in IE 11. Could you try to detect the browser version while loading the page, if IE 11 is detected, then redirect user to a page with some note to let users know what browser they should use.

allthesignals commented 5 years ago

Thanks @CeciliaCY can you try this deploy branch?

CeciliaCY commented 5 years ago

deploy branch works @allthesignals

allthesignals commented 5 years ago

~I think this is the next issue: https://github.com/mapbox/mapbox-gl-js/issues/3422~

A new commit in the PR should address most issues, but there are others including wizard not working.

We should run the test suite against IE 11 and debug accordingly.