allthesignals commented 5 years ago

Addresses #532 but does not close. There are still downstream issues but the initial landing page works.

codecov[bot] commented 5 years ago

Codecov Report

Merging #533 into develop will decrease coverage by 0.1%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #533      +/-   ##
===========================================
- Coverage     85.8%   85.69%   -0.11%     
===========================================
  Files           69       69              
  Lines          965      965              
===========================================
- Hits           828      827       -1     
- Misses         137      138       +1

Impacted Files	Coverage Δ
app/components/project-geometries/modes/draw.js	`87.09% <0%> (-1.08%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0ce118...5549e8d. Read the comment docs.

ghost commented 5 years ago

dont forget to squash commits ! @allthesignals

andycochran commented 5 years ago

On IE11 in BrowserStack, when I try to navigate through the wizard, I make a Dev Site, go to the Project Area question, choose a type, then there's no Dev Site on the map. After drawing a Project Area, I'm brought back to the Dev Site question. (It's very laggy in BrowserStack tho. I'd like to check this on a Windows desktop.)

allthesignals commented 5 years ago

@andycochran again, this needs to be merged now - the issues you raise already exist in develop

NYCPlanning / labs-applicantmaps

532 ie 11 compatibility #533

Codecov Report