search

NYCPlanning / labs-applicantmaps

5 stars 5 forks source link

543 Test Fix #544

Closed allthesignals closed 5 years ago

allthesignals commented 5 years ago

This addresses #543 by bumping versions for ember-concurrency, and fixing downstream version conflict issues.

The fix uses the "resolutions" feature in yarn to force yarn to fetch exact versions of dependencies, ignoring minor version drift.

This also prefixes JOBS=2 in yarn test to get around the issue documented here: https://github.com/emberjs/ember.js/issues/15641

allthesignals commented 5 years ago

So you're using these Yarn "resolutions" in place of ember-cli-version-checker? I saw that you removed this as well. Was ember-cli-version-checker not catching everything?

@trbmcginnis

So that yarn.lock file gets programmatically generated by yarn, so I don't actually consciously change anything in the file. It's the side effect of installing new packages.

Somewhere upstream dependencies, something changed and they removed or bumped that dependency.

This entire problem could have something to do with that package, but I'm not completely sure.